Hidden section still appears in sidebar

[rijenkii]

Description

When hiding a section in configuration, links to the section and its children remain in the sidebar.

Steps to reproduce

Paste the following into the playground:

Schema

{
  "asyncapi": "3.0.0",
  "info": {
    "title": "Reproduction",
    "version": "1.0.0"
  },
  "operations": {
    "test": {
      "action": "receive",
      "channel": { "$ref": "#/channels/test" }
    }
  },
  "channels": {
    "test": {
      "address": "/test",
      "messages": {
        "test": { "$ref": "#/components/messages/test" }
      }
    }
  },
  "components": {
    "messages": {
      "test": {
        "payload": {
          "type": "object",
          "properties": {
            "test": {
              "description": "test",
              "type": "string",
              "pattern": "^(?:helloworld)+$"
            }
          },
          "required": ["test"]
        }
      }
    }
  }
}

Configuration

{
  "show": {
    "sidebar": true,
    "info": true,
    "operations": true,
    "servers": true,
    "messages": false,
    "schemas": true,
    "errors": true
  },
  "expand":{
    "messageExamples": false
  },
  "sidebar": {
    "showServers": "byDefault",
    "showOperations": "byDefault"
  }
}

Expected result

Section "messages" to be removed from the page and from the sidebar.

Actual result

Section "messages" is removed from the page, but not from the sidebar.

Troubleshooting

N/A

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[rijenkii]

Still an issue.

[gcx-seb]

Ran into this today, too

[AceTheCreator]

I'd look into this

[asyncapi-bot]

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[gcx-seb]

I see it's now working in the playground.

But on CLI I'm still running into this 🤔

$ asyncapi --version          
@asyncapi/cli/2.3.2 linux-x64 node-v20.17.0

$ asyncapi generate fromTemplate asyncapi.yaml \
        @asyncapi/html-template \
        --param \
        singleFile=true \
        config='{"show":{"messages":false},"expand":{"messageExamples":true},"sidebar":{"showOperations":"byOperationsTags"}}' \
        --output example

Any ideas?

Edit: ah, looks like html-template still needs an update

[rsulzenbacher]

Hi! Same issue here. In playground everything is looking good, but on CLI (generator) not.
Is there any solution? Or how can I regenerate/update html-template myself?

[gcx-seb]

Yeah I think the issue is that @asyncapi/html-template depends on an older version of @asyncapi/react-component (^1.2.13), see https://github.com/asyncapi/html-template/blob/v2.3.13/package.json#L43

Not sure if it would be easily possible to upgrade from major version 1 to 2 🤷