fix: modelina supporting asyncapi v3 #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Souvikns
requested review from
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
|
@Souvikns could you push a empty commit. The sonarcloud analysis seems to be stuck. |
|
Sonarcloud is still not working @Shurtu-gal |
Shurtu-gal
approved these changes
Jul 12, 2024
|
@derberg any ideas for why this isn't working |
|
@Shurtu-gal I have no idea. My fix is go to Sonarcloud, remove project, add project and works Then again it fails. I suggest you folks to make it a non-mandatory check, so a check that even if fails, you may merge. we need to work on asyncapi/.github#306 but also in this issue you will see a hint from Sergio, that it might be just because of some silly change sonar did on their side with check name |
didacrios
approved these changes
Jul 12, 2024
|
/rtm |
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Can this be removed in generate fromTemplate as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the check for spec v3 as now modelina support AsyncAPI spec v3.
Related issue(s)
See also #1376