Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build and publish docker image for arm and amd platforms #1004

Merged
merged 6 commits into from
Oct 11, 2023
Merged

feat: build and publish docker image for arm and amd platforms #1004

merged 6 commits into from
Oct 11, 2023

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Jul 3, 2023

  1. Use official docker github actions
  2. Support arm and amd architectures
  3. Generator version as a Dockerfile argument

github-actions[bot]
github-actions bot reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg
derberg reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate why you need ASYNCAPI_GENERATOR_VERSION if previous images for old versions are there anyway?

also, are you sure you want to invest in it? we will be deprecating ag as all the CLI-related dev power goes to https://github.com/asyncapi/cli. All missing features are already there in the CLI, so pretty soon we will open an issue that address these plans

Dockerfile Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ferror Ferror requested a review from derberg July 5, 2023 13:25
@derberg
Copy link
Member

derberg commented Jul 12, 2023

@Ferror before I proceed I want to make sure you saw this 👇🏼

also, are you sure you want to invest in it? we will be deprecating ag as all the CLI-related dev power goes to https://github.com/asyncapi/cli. All missing features are already there in the CLI, so pretty soon we will open an issue that address these plans

@derberg
Copy link
Member

derberg commented Jul 12, 2023

I also made deprecation plans official as we were so far just mentioning it is come issues/prs -> #1008

@Ferror
Copy link
Contributor Author

Ferror commented Jul 12, 2023

@Ferror before I proceed I want to make sure you saw this 👇🏼

also, are you sure you want to invest in it? we will be deprecating ag as all the CLI-related dev power goes to https://github.com/asyncapi/cli. All missing features are already there in the CLI, so pretty soon we will open an issue that address these plans

Yea. Deprecation doesn't mean we shouldn't add such improvement :)

derberg
derberg reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ferror I saw you were force pushing something recently, but do not see any new things about delays

@derberg
Copy link
Member

derberg commented Oct 4, 2023 •
edited
Loading

@Ferror yo, should we keep it open? do you plan to work on it?

@Ferror
Copy link
Contributor Author

Ferror commented Oct 6, 2023

@derberg I added the sleep. Personally, i dont think it will be required, but lets do little step. I have an idea how to handle more complex workflows. When there will be some space to refactor them then we can enter :)

@Ferror Ferror requested a review from derberg October 6, 2023 18:30
@Ferror Ferror requested a review from derberg October 9, 2023 21:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man

@derberg
Copy link
Member

derberg commented Oct 11, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit f360fa6 into asyncapi:master Oct 11, 2023
15 checks passed
@Ferror Ferror deleted the docker-release branch October 11, 2023 11:51
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferror @derberg @asyncapi-bot