Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Parser-API version 2 support #1017

Merged
merged 9 commits into from
Sep 14, 2023
Merged

feat: add Parser-API version 2 support #1017

merged 9 commits into from
Sep 14, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Aug 1, 2023 •
edited
Loading

Description
This PR adds support for the parserApi v2, which enables templates to work with it and effectively enables AsyncAPI v3 in templates.

Tested with asyncapi/markdown-template#360
Tested with asyncapi/html-template#448

Fixes #979

@jonaslagoni jonaslagoni mentioned this pull request Aug 3, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni marked this pull request as draft August 17, 2023 11:41
@jonaslagoni jonaslagoni mentioned this pull request Sep 7, 2023
Closed
6 tasks
@jonaslagoni jonaslagoni changed the title feat: add support for v3 feat: add parserApi version 2 Sep 7, 2023
@jonaslagoni jonaslagoni marked this pull request as ready for review September 11, 2023 11:21
@jonaslagoni jonaslagoni mentioned this pull request Sep 11, 2023
Merged
derberg
derberg previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

lib/parser.js Show resolved Hide resolved
docs/configuration-file.md Show resolved Hide resolved
docs/generator-template.md Outdated Show resolved Hide resolved
@derberg derberg changed the title feat: add parserApi version 2 feat: add Parser-API version 2 support Sep 13, 2023
@derberg derberg dismissed their stale review September 13, 2023 13:34

dunno why approved :)

@jonaslagoni jonaslagoni requested a review from derberg September 14, 2023 10:33
derberg
derberg reviewed Sep 14, 2023
View reviewed changes
lib/parser.js Outdated Show resolved Hide resolved
lib/parser.js Outdated Show resolved Hide resolved
lib/parser.js Outdated Show resolved Hide resolved
jonaslagoni and others added 2 commits September 14, 2023 15:12
@jonaslagoni @derberg
Update lib/parser.js
7037151 
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@jonaslagoni @derberg
Apply suggestions from code review
1ca6188 
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni requested a review from derberg September 14, 2023 13:16
derberg
derberg approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonaslagoni
Copy link
Member Author

/rtm

@jonaslagoni
Copy link
Member Author

Thanks for the review @derberg 🙇

@asyncapi-bot asyncapi-bot merged commit 60f8e62 into master Sep 14, 2023
16 checks passed
@asyncapi-bot asyncapi-bot deleted the add-v3-support branch September 14, 2023 13:20
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@Florence-Njeri Florence-Njeri Awaiting requested review from Florence-Njeri Florence-Njeri is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in generator
3 participants
@jonaslagoni @asyncapi-bot @derberg