Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest easy issues #1272

Open
derberg opened this issue Oct 2, 2024 · 15 comments
Open

Hacktoberfest easy issues #1272

derberg opened this issue Oct 2, 2024 · 15 comments
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com

Comments

@derberg
Copy link
Member

derberg commented Oct 2, 2024

I'm not going to create separate issues as this would be too much work that is not really needed.

So let us experiment and see if one issue is enough.

SonarCloud suggestions

50 small fixes can be done to improve the quality of this project. All are listed here: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator

Process of work:

  1. Go to https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator
  2. Pick an issue and in comment of this GH issue write that you will work on this given SonarCloud issue, link it like so: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKX and write how you will fix it
  3. Once I give a green light, please go ahead and open a PR
  4. In PR do not say that given PR fixes this GitHub Issue but is just related to it

Tests

Use our new dev guide https://github.com/asyncapi/generator/blob/master/Development.md and install the project and run tests. At the run summary you will see the test coverage overview. You can just open a PR that adds one of the missing tests. In description just make sure you show test coverage report before and then after adding the test, so it makes review easier, and shows improvements are really there.

Should be good 😄
Happy Hacktoberfesting!

@derberg derberg added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 2, 2024
@thebedigupta
Copy link
Contributor

@AceTheCreator
Copy link
Member

Hey I wanted to work on this will you please assigned to me https://sonarcloud.io/project/issues?cleanCodeAttributeCategories=INTENTIONAL&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sekEgviDxNeZYbKm

@thebedigupta we don't assign issues, please go ahead and work on it :)

@thebedigupta
Copy link
Contributor

Should I have to solve all issues in One PR?

@ManikantaMandala
Copy link
Contributor

I also want to work on these issues

@DhairyaMajmudar
Copy link
Contributor

Should I have to solve all issues in One PR?

No need to solve all issues in one PR instead open separate PRs resolving issues which will help maintainers to efficient review PR

@rishabhr4
Copy link
Contributor

@Gmin2
Copy link
Collaborator

Gmin2 commented Oct 3, 2024

@rishabhr4
Copy link
Contributor

Hey I wanted to work on this issue https://sonarcloud.io/project/issues?languages=js&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKZ

Raise a PR if you think so

Raised a PR , please let me know if any changes are required

@ManikantaMandala
Copy link
Contributor

raised a pr for this issue

@yashsaraswat2004
Copy link

Hey, I want to work on this issue : - https://sonarcloud.io/project/issues?open=AZD-TPs2DKL_zKkK1XuA&id=asyncapi_generator . Can I work?

@AceTheCreator
Copy link
Member

Hey folks, we do not assign issues, if you see any issue/s you're interested in and there's currently no PR for it, kindly go ahead and work on it 🚀

@derberg
Copy link
Member Author

derberg commented Oct 7, 2024

hey folks, be patient here 🙏🏼 there are many PRs that we need to review, also test runs are not fast. If you wanna speed up, make sure you run tests locally and check if the pass. I already noticed in one PR that contributor did not do it, and then merging have to take more time as they need to followup, etc

@derberg
Copy link
Member Author

derberg commented Oct 8, 2024

also, folks please do not address any fixes or anything in cli.js file

@D-I-R-M
Copy link
Contributor

D-I-R-M commented Oct 18, 2024

@thebedigupta
Copy link
Contributor

Hey I wanted to work on this issue
https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_generator&open=AZB4sejpgviDxNeZYbKd&tab=code

Before working on this have a look at pinned issue

No need to ask for assign this issue if you think you can then go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

9 participants