-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize dockerfile #1298
perf: optimize dockerfile #1298
Conversation
|
@@ -8,14 +6,17 @@ WORKDIR /app | |||
ENV PUPPETEER_EXECUTABLE_PATH /usr/bin/chromium-browser | |||
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true | |||
|
|||
# Include the ARG instruction in this build stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please include one line comment explaining why it should be included in build stage
apps/generator/Dockerfile
Outdated
# Install dependencies and AsyncAPI Generator in a single RUN command | ||
RUN apk --no-cache add git chromium && \ | ||
rm -rf /var/cache/apk/* && \ | ||
npm install -g --ignore-scripts "@asyncapi/generator@${ASYNCAPI_GENERATOR_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sonar was just suggesting to surround only the variable name with double quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once you react to all comments, please also run build of the docker image locally + use the docker to verify all works as expected
I am updating test results file Please review it and then just tell me if I did something wrong |
I see in test result that you did run
I mean't - please try to use the image you build locally, to check if generation still works going with this should do the trick |
@derberg I was trying to understand where things goes wrong Give me some time if you have any suggestions on how to run image then please let me know |
Quality Gate passedIssues Measures |
but the command that is under the link I provided, isn't it working? |
Update the test results Please check again |
@thebedigupta you mean in description? I don't see info in test result that |
no follow-up from contributor - closing PR, we do not want to keep such inactive PRs open you can restart the work anytime you want, you or any other contributor - just feel free to open another PR. You see previous comments, you know what has to be improved |
Description
Updated Test Results test-results.md
Problems that I worked in this PR
I solved this issue after reading sonarcloud suggestion and how it work