Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new ParserAPI #825

Closed
magicmatatjahu opened this issue Sep 6, 2022 · 2 comments · Fixed by #960
Closed

Integrate new ParserAPI #825

magicmatatjahu opened this issue Sep 6, 2022 · 2 comments · Fixed by #960
Labels
enhancement New feature or request

Comments

@magicmatatjahu
Copy link
Member

We should integrate new ParserAPI in Generator but with fallback compatibility with old one, solution described in the asyncapi/parser-js#585:

  • add support for new (optional!) field in template's config, apiVersion with possible values, v2 and v1 - v1 should be default value
  • integrate new parser-js version in generator
  • add possible tests
  • update docs
@jonaslagoni
Copy link
Member

This is actually blocking templates from using the new Modelina next branch... At least in the general sense. I tried upgrading to the .NET NATS template to use the new branch, but it's conflicting with the parsed AsyncAPI document not having the new parser API when using the AsyncAPI input processor in Modelina.

I could reparse everything again, but that does not seem right to do either 😄

Any suggestions how to fix it?

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants