Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate env.json with valid Kafka bootstrap addresses #188

Merged
merged 3 commits into from
Mar 9, 2024
Merged

fix: populate env.json with valid Kafka bootstrap addresses #188

merged 3 commits into from
Mar 9, 2024

Conversation

dalelane
Copy link
Collaborator

@dalelane dalelane commented Mar 8, 2024

The generator was putting the "kafka-secure://" protocol prefix in the bootstrap address for generated Kafka apps, which the Kafka client library rejects as an invalid URL.

This commit uses the hostname if it is available (v3 docs) but falls back to using the url otherwise (v2 docs).

@dalelane
fix: populate env.json with valid Kafka bootstrap addresses
f8563c5 
The generator was putting the "kafka-secure://" protocol prefix
in the bootstrap address for generated Kafka apps, which the Kafka
client library rejects as an invalid URL.

This commit uses the hostname if it is available (v3 docs) but
falls back to using the url otherwise (v2 docs).

Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
@dalelane
Copy link
Collaborator Author

dalelane commented Mar 8, 2024

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @dalelane! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@dalelane
Copy link
Collaborator Author

dalelane commented Mar 8, 2024

/rtm /au

@asyncapi-bot
Copy link
Contributor

Hello, @dalelane! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

@dalelane
Copy link
Collaborator Author

dalelane commented Mar 9, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 82ede4d into asyncapi:master Mar 9, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEFFLUFC JEFFLUFC JEFFLUFC approved these changes

@AGurlhosur AGurlhosur Awaiting requested review from AGurlhosur AGurlhosur is a code owner

@dan-r dan-r Awaiting requested review from dan-r dan-r is a code owner

@KieranM1999 KieranM1999 Awaiting requested review from KieranM1999 KieranM1999 is a code owner

@lewis-relph lewis-relph Awaiting requested review from lewis-relph lewis-relph is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
autoupdate ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalelane @asyncapi-bot @JEFFLUFC