Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement TLS support #76

Merged
merged 6 commits into from
Nov 13, 2022
Merged

feat: implement TLS support #76

merged 6 commits into from
Nov 13, 2022

Conversation

dan-r
Copy link
Member

@dan-r dan-r commented Nov 3, 2022

As per #75, this allows the code generator to use the cipher spec from the asyncapi spec.

@dan-r dan-r changed the title Implement TLS support feat: implement TLS support Nov 3, 2022
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

if (ciphers[cipher] === undefined) {
throw new Error('An invalid cipher spec was provided. Please see https://ibm.biz/mq-cipher-mappings');
Copy link
Collaborator

@dalelane dalelane Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch 👍

@dan-r
Copy link
Member Author

dan-r commented Nov 13, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 40257b8 into asyncapi:master Nov 13, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants