Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added C# class and enum generator #316

Merged
merged 14 commits into from
Aug 12, 2021
Merged

feat: added C# class and enum generator #316

merged 14 commits into from
Aug 12, 2021

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds C# class and enum generator alongside tests.

@coveralls
Copy link

coveralls commented Aug 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1123563029

  • 132 of 137 (96.35%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 93.315%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/csharp/CSharpGenerator.ts 21 22 95.45%
src/generators/csharp/CSharpRenderer.ts 25 29 86.21%
Totals Coverage Status
Change from base Build 1123413218: -0.3%
Covered Lines: 1712
Relevant Lines: 1746
💛 - Coveralls

@jonaslagoni jonaslagoni marked this pull request as draft August 9, 2021 17:18
@jonaslagoni jonaslagoni marked this pull request as ready for review August 9, 2021 17:38
magicmatatjahu
magicmatatjahu requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with C# language so I only add the comments related to the code.

src/generators/csharp/renderers/ClassRenderer.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@jonaslagoni
Copy link
Member Author

Thanks 🎉

@jonaslagoni jonaslagoni merged commit 1dfbe58 into asyncapi:master Aug 12, 2021
@jonaslagoni jonaslagoni deleted the feature/csharp branch August 12, 2021 10:44
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaslagoni @coveralls @asyncapi-bot @magicmatatjahu