Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust filters and config parsing for websocket protocol #200

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix: adjust filters and config parsing for websocket protocol #200

merged 2 commits into from
Mar 29, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 28, 2023

error:

# asyncapi generate fromTemplate asyncapi.yaml @asyncapi/nodejs-template -o output -p server=dev
Generation in progress. Keep calm and wait a bit... done

Generator Error: (/usr/lib/node_modules/@asyncapi/cli/node_modules/@asyncapi/generator/node_modules/@asyncapi/nodejs-template/template/config/common.yml) [Line 4, Column 21]
  Error: filter not found: replaceVariablesWithValues

taken from https://asyncapi.slack.com/archives/CQVJXFNQL/p1680006402805839

it was broken long time ago in #123 but just nobody used this template with websocket protocol, thus invalid filter was never called

@derberg derberg changed the title fix: rename filter to the existing one fix: rename filter for variable replacement in websocket protocol Mar 28, 2023
@derberg derberg changed the title fix: rename filter for variable replacement in websocket protocol fix: adjust filters and config parsing for websocket protocol Mar 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member Author

derberg commented Mar 28, 2023

code smells are related to regular expressions, that some escape characters are not needed and can be removed, but I'm scared to remove those 😆

@fmvilas
Copy link
Member

fmvilas commented Mar 28, 2023

LOL I always have the same fear.

@derberg
Copy link
Member Author

derberg commented Mar 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 2a1167f into asyncapi:master Mar 29, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kaushik-rishi pushed a commit to kaushik-rishi/nodejs-template that referenced this pull request Aug 23, 2023
@asyncapi-bot
chore: update code of conduct (asyncapi#200)
e21b603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derberg @fmvilas @asyncapi-bot