Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong Instructions in the readme.md to run the server-api locally #363

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

maheshchandra10
Copy link
Contributor

Fixes #362

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔 Thanks for the fix @maheshchandra10 !

@smoya
Copy link
Member

smoya commented Oct 24, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 555a25a into asyncapi:master Oct 24, 2023
21 checks passed
@smoya
Copy link
Member

smoya commented Oct 24, 2023

I just noticed the commit prefix shouldn't have to be fix: but doc:. Now we are triggering a release 😓

@princerajpoot20
Copy link
Member

🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Instructions in the readme.md to run the server-api locally
4 participants