Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reusable tags and externalDocs objects #245

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Jul 26, 2022

Description

Spec PR asyncapi/spec#792

Related issue(s)
Part of asyncapi/spec#792
Part of asyncapi/spec#796

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dalelane
dalelane previously approved these changes Jul 29, 2022
fmvilas
fmvilas previously approved these changes Jul 29, 2022
derberg
derberg previously approved these changes Oct 11, 2022
@derberg
Copy link
Member

derberg commented Oct 11, 2022

please do not merge yet because of #264 (comment)

/dnm

@magicmatatjahu magicmatatjahu dismissed stale reviews from derberg, fmvilas, and dalelane via afad192 February 6, 2023 11:24
@magicmatatjahu magicmatatjahu force-pushed the feat/tags-externalDocs-in-components branch from 5f09089 to afad192 Compare February 6, 2023 11:24
@magicmatatjahu
Copy link
Member Author

@derberg @fmvilas @char0n @dalelane @smoya Someone from you could check that? Thanks!

@magicmatatjahu
Copy link
Member Author

/rtm

@magicmatatjahu
Copy link
Member Author

/rtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 290bbf5 into asyncapi:next-major-spec Feb 7, 2023
@magicmatatjahu magicmatatjahu deleted the feat/tags-externalDocs-in-components branch February 7, 2023 16:17
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants