-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add host and pathname fields in server object #329
feat: add host and pathname fields in server object #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job!
@magicmatatjahu we theoretically can, here are the representation in pseudo context-free grammar for host and pathname. host:
pathname As far as I understand this is https://url.spec.whatwg.org/#dom-url-pathname without
It should be possible to convert these context-free grammars into regular expressions. |
I would create another issue for this. This is the kind of task that can quickly become a rabbithole. |
Kudos, SonarCloud Quality Gate passed! |
/rtm |
🎉 This PR is included in version 5.0.0-next-major-spec.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add
host
andpathname
fields in server object.Related issue(s)
Part of asyncapi/spec#888