-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all recommended and must supported schema formats #365
feat: add all recommended and must supported schema formats #365
Conversation
Kudos, SonarCloud Quality Gate passed! |
If tooling will support proto but it is not listed here it is not a problem? |
These are just all known schema formats listed in https://www.asyncapi.com/docs/reference/specification/v2.6.0#messageObjectSchemaFormatTable We cannot add values we haven't agreed upon, you can of course still use custom ones. Adding new keys for other schema formats is part of the spec discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like manual stuff that will have to be updated with each release
not a problem, just mentioning because this requires updates in readme, and probably script that generates new version definitions?
I'll see if I can include it in the script, that would be easiest yea. |
Kudos, SonarCloud Quality Gate passed! |
Alright, I made a few changes.
Depending on whether this or #370 is merged first, we need to adapt the function |
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Applied your suggestions @fmvilas and applied the recent changes from master. I adapted the add new version script so the validation of |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg did you test the auto-suggestion feature for schemaFormat values, not so much whether |
@derberg yeeep, perfect 👌 |
/rtm |
@fmvilas is out on holidays next 4 weeks, and for not PR is blocked as he requested changes to it in the past. I will use admin rights to dismiss his request for changes as we won't wait a month for him |
🎉 This PR is included in version 6.0.0-next-major-spec.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds all the MUST and RECOMMENDED supported schema formats. This is to enable auto-completion more than anything because the underlying type is
string
, it's only to help know which known values are there.