Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update with latest bindings changes #450

Merged
merged 15 commits into from
Nov 21, 2023
Merged

feat: update with latest bindings changes #450

merged 15 commits into from
Nov 21, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Nov 17, 2023 •
edited
Loading

Description

This PR adds the following changes:

  • Updates the codeowners file with the latest bindings owners adding @mboss37, @rcoppen, @SrfHead, @dpwdec, @iancooper
  • Removed .keep files where needed
  • Adapted websocket JSON Schema files to use the 3.0.0 spec files
  • Add sqs bindings
  • Add jns bindings
  • Adapted HTTP bindings
  • Adapted anypointmq bindings
  • Changed all specification extension patterns from ^x-[\\w\\d\\.\\-\\_]+$ to ^x-[\\w\\d\\.\\x2d_]+$
  • Changed all references to use v3

@jonaslagoni jonaslagoni mentioned this pull request Nov 17, 2023
Merged
@jonaslagoni jonaslagoni marked this pull request as ready for review November 17, 2023 22:13
jonaslagoni
jonaslagoni commented Nov 17, 2023
View reviewed changes
CODEOWNERS Outdated
Comment on lines 10 to 21
/bindings/anypointmq/ @mboss37 @GeraldLoeffler
/bindings/ibmmq/ @rcoppen
/bindings/jms/ @rcoppen @SrfHead
/bindings/kafka/ @lbroudoux @dalelane
/bindings/googlepubsub/ @whitlockjc
/bindings/solace/ @damaru-inc @CameronRushton
/bindings/pulsar/ @VisualBean
/bindings/sns/ @dpwdec @iancooper
/bindings/sqs/ @dpwdec @iancooper

/bindings/anypointmq/ @GeraldLoeffler
/bindings/ibmmq/ @rcoppen
/bindings/kafka/ @lbroudoux @dalelane
/bindings/googlepubsub/ @whitlockjc
/bindings/solace/ @damaru-inc @CameronRushton
/bindings/*.json @KhudaDad414
/bindings/pulsar/ @VisualBean No newline at end of file
/bindings/*.json @KhudaDad414
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboss37, @rcoppen, @SrfHead, @dpwdec, @iancooper the JSON Schema files for the bindings are as of v3 being validated alongside the specification, which is why the files have been moved from the bindings repo. @derberg will at some point send you an invite to join the spec-json-schemas repository as a maintainer so you still have full ownership of the bindings 🙂

dalelane
dalelane approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once the new members are invited

@derberg derberg merged commit 71eb67c into asyncapi:next-major-spec Nov 21, 2023
10 checks passed
@derberg
Copy link
Member

derberg commented Nov 21, 2023

merged instead of squash and merge

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mboss37
Copy link
Collaborator

mboss37 commented Nov 21, 2023

I don't have any pending invite. So looks good for me

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaslagoni @derberg @mboss37 @asyncapi-bot @dalelane