Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate object type for the headers in the message trait #82

Closed
magicmatatjahu opened this issue Jul 29, 2021 · 3 comments · Fixed by #102
Closed

Validate object type for the headers in the message trait #82

magicmatatjahu opened this issue Jul 29, 2021 · 3 comments · Fixed by #102
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Jul 29, 2021

As we read in the specification about headers field for Message Object:

image

we validate it by the lines:

https://github.com/asyncapi/asyncapi-node/blob/master/schemas/2.1.0.json#L644-L657

However we should also validate the headers in the Message Trait Object:

https://github.com/asyncapi/asyncapi-node/blob/master/schemas/2.1.0.json#L885-L892

JSON Schemas for 2.0.0 and 2.1.0 should be updated.

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants