Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Message Trait examples field #85

Merged
merged 3 commits into from
Sep 20, 2021
Merged

fix: fix Message Trait examples field #85

merged 3 commits into from
Sep 20, 2021

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Aug 11, 2021

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@char0n char0n mentioned this pull request Aug 11, 2021
Merged
github-actions[bot]
github-actions bot reviewed Aug 11, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@char0n char0n changed the title fix(schema): fix Message Trait example field fix(schema): fix Message Trait examples field Aug 11, 2021
@fmvilas
Copy link
Member

fmvilas commented Sep 15, 2021

@derberg @magicmatatjahu mind having a look too?

@derberg derberg changed the title fix(schema): fix Message Trait examples field fix: fix Message Trait examples field Sep 15, 2021
derberg
derberg approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only removed schema scope from fix prefix as the whole repo is about schema anyway, and tbh we did not use scopes for fix and feat and I'm not sure what effect it has on release process 😅

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit 4bd5b64 into asyncapi:master Sep 20, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-2021-09-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
released on @2021-09-release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@char0n @fmvilas @asyncapi-bot @derberg @magicmatatjahu