You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
// check to see if context has expired during our delay
ifctx.Err() !=nil {
msg:=NotifyResult{
Val: fmt.Sprintf(
"sendMessage: context expired or cancelled at %v: %v, attempting to abort message submission",
time.Now().Format("15:04:05"),
ctx.Err().Error(),
),
Success: false,
}
log.Debug(msg.Val)
returnmsg
}
prompted me to quickly stub in this FIXME entry that I later removed for inclusion into this GH issue:
// FIXME: Need to update wording of constant, docs, etc to emphasize that// the delay is enforced regardless of whether the notification attempt is// the first, or a retry
Since I opted to apply the delay regardless of the delivery attempt, I should probably "unhook" the "retries" bit from the associated variables/constants associated with the delay. For example, it is in the function parameter list:
While working on atc0005/brick#4, I was again reminded of how I ended up implementing notification delays:
This comment above this portion of the select block:
bounce/cmd/bounce/message.go
Lines 244 to 272 in cfbe63e
prompted me to quickly stub in this FIXME entry that I later removed for inclusion into this GH issue:
Since I opted to apply the delay regardless of the delivery attempt, I should probably "unhook" the "retries" bit from the associated variables/constants associated with the delay. For example, it is in the function parameter list:
bounce/cmd/bounce/message.go
Lines 194 to 202 in cfbe63e
and is also used in the exported
SendMessage()
function from the atc0005/send2teams project:bounce/cmd/bounce/message.go
Lines 274 to 276 in cfbe63e
As of this writing I've not reviewed that project yet to see if it has similar artifacts from the early design/implementation work, but it's likely.
The text was updated successfully, but these errors were encountered: