Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkey integration #119

Open
kissu opened this issue Jul 9, 2024 · 4 comments · May be fixed by #149
Open

Passkey integration #119

kissu opened this issue Jul 9, 2024 · 4 comments · May be fixed by #149
Labels
enhancement New feature or request

Comments

@kissu
Copy link

kissu commented Jul 9, 2024

Hey! Not sure how hard it is to implement some Passkeys or even if it's planned but creating the issue for it. 🙂

@Gerbuuun
Copy link
Contributor

Gerbuuun commented Jul 24, 2024

I'm almost done with my implementation but it does have a dependency on pilcrow's oslo package.
I could create a PR to this repo within a few days.

I think oslo has very good validation functions but this module should also have some utils that create the keys / challenges etc.

I think the minimum would be:

  • A composable which handles key and signature creation on client side
  • Nitro endpoint that returns credential options.
  • Server util for authenticator validation (just like oslo)
  • Server util for credential validation (just like oslo)

@atinux what do you think about the dependency on oslo?
Maybe it's better to copy the necessary functions (with reference) instead of depending on the whole package

edit: going on vacation until the 12th. Won't work on this until then

@EnjoyKojima
Copy link

Hello!!
By olso, do you mean this package?
I look forward to your PR being merged!

@Gerbuuun
Copy link
Contributor

Gerbuuun commented Jul 30, 2024

Yes, the webauthn part has the necessary cryptographic key validation functions. Also fully typed and runtime agnostic which is important

@atinux atinux added the enhancement New feature or request label Jul 30, 2024
@atinux
Copy link
Owner

atinux commented Jul 30, 2024

If we can avoid importing oslo but having the utilities into this package it would be great so we can be sure that it works on the edge runtime too.

Happy to see your PR @Gerbuuun

@Gerbuuun Gerbuuun linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants