Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combining support (aka grouping, merging) #511

Closed
alexreardon opened this issue May 18, 2018 · 8 comments
Closed

Add combining support (aka grouping, merging) #511

alexreardon opened this issue May 18, 2018 · 8 comments

Comments

@alexreardon
Copy link
Collaborator

Adding the ability to hover a Draggable on top of another one.

  • This would change the sliding of items to allow for a period of overlap
  • The onDragUpdate > DragUpdate type would need to be updated to include the grouping information
  • The onDragEnd > DragResult type would also need to be updated
  • keyboard interactions would need to be aware of grouping
  • A Droppable would need to opt into allowing it's child Draggables to be groupable (still need to figure out what the opt in story looks like)
@hieronx
Copy link

hieronx commented May 18, 2018

Really interesting idea! I wonder if this would enable the following use case:

Let's say you have a sidebar on the left with a list of projects, which can be reordered. On the right side, you have a list of items within the currently selected project, which can be reordered as well. You can also drag an item to the sidebar, hovering over a project, at which point it will be moved to that particular project when dropped.

I think this would require some kind of groupableType prop on Droppables. The Droppable of the sidebar would be something like

<Droppable type="project" groupable={true} groupableType="item" />

What do you think @alexreardon ?

Also, note that the Trello link you shared is not working, it shows the following error:

Card not found.
This card may be on a private board. If someone gave you this link, they may need to invite you to one of their boards or teams.

@alexreardon
Copy link
Collaborator Author

The trello board is private. Lame that the trello link is public.

API to be confirmed, but yes, this is to do with allowing grouping of draggables

@alexreardon
Copy link
Collaborator Author

Making progress

grouping-teaser

@hieronx
Copy link

hieronx commented Aug 22, 2018

Looks awesome, @alexreardon !

Would it be possible to add some kind of attribute like groupableType, so you can only group items of a certain type on an item? That would be really helpful for the use case I described above.

@alexreardon
Copy link
Collaborator Author

grouping-with-keyboard

Combining with a keyboard 👍

@alexreardon alexreardon changed the title Add grouping / hover support Add ~~grouping / hover~~ combining support Sep 11, 2018
@alexreardon alexreardon changed the title Add ~~grouping / hover~~ combining support Add combining (grouping) support Sep 11, 2018
@yduman
Copy link

yduman commented Sep 28, 2018

I am really looking forward for this feature, since it will be one of the core actions of my project. You said on another issue that this will be landing on version 10. When can we expect this version? Any approximate date?

@alexreardon alexreardon changed the title Add combining (grouping) support Add combining support (aka grouping, merging) Oct 7, 2018
@mpseidel
Copy link

Nice one. Looking forward to using it for feature I plan to build.

@alexreardon
Copy link
Collaborator Author

Closed by #838. See version 10 release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants