Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Error message from atom.workspace.scan() using ripgrep can take the whole screen #1120

Open
1 task done
ariasuni opened this issue Apr 17, 2020 · 0 comments
Open
1 task done

Comments

@ariasuni
Copy link
Contributor

ariasuni commented Apr 17, 2020

Prerequisites

Description

Screenshot_20200417_144552

Steps to Reproduce

Make a lot of symbolic links to non-exist files under Linux in the folder Atom is currently opened in.

Expected behavior:

Size of the error message is limited so that an unusual amount of text error doesn’t make the find-and-replace unusable.

Actual behavior:

Size of the error message is taking the whole screen, we can’t see the fields or the results anymore.

Reproduces how often:

All the time.

Versions

Atom : 1.45.0
Electron: 4.2.12
Chrome : 69.0.3497.128
Node : 10.11.0
apm 2.4.5
npm 6.14.4
node 13.13.0 x64
atom 1.45.0
python 3.8.2
git 2.26.1

Additional Information

I bisected Firefox and the build process happens to use symbolic links for a lot of resources. But they’re not cleaned up and I didn’t knew or care about it until it messed up Atom. Just developing and updating Firefox source code means that it will happens and become worse as files are renamed in the source code.

Rigrep doesn’t care if there are dead symbolic links in the folders it searches in and neither should Atom.

Linked issue: atom/atom#20637

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant