From b4146b827988b3483151de761ab097091cc32857 Mon Sep 17 00:00:00 2001 From: James Carnegie Date: Tue, 11 Apr 2017 14:26:05 +0100 Subject: [PATCH] Prep for 0.23.0 release --- operations/messages/MessageRendering.ts | 69 +++++++++++-------------- package.json | 4 +- 2 files changed, 31 insertions(+), 42 deletions(-) diff --git a/operations/messages/MessageRendering.ts b/operations/messages/MessageRendering.ts index ebccce0..aa1d8fa 100644 --- a/operations/messages/MessageRendering.ts +++ b/operations/messages/MessageRendering.ts @@ -54,19 +54,16 @@ const listIssues = `{ function renderIssues(issuesList: Issue[], chatSystem?: string): string { const last = "last"; issuesList[issuesList.length - 1][last] = true; // horrible mustache hack - try { - return mustache.render(listIssues, { - assignee() { - return this.assignee !== undefined; - }, - closed() { - return this.state === "closed"; - }, - issues: issuesList, - }); - } catch (ex) { - return `Failed to render message using template: ${ex}`; - } + + return mustache.render(listIssues, { + assignee() { + return this.assignee !== undefined; + }, + closed() { + return this.state === "closed"; + }, + issues: issuesList, + }); } const failure = `{ @@ -89,41 +86,33 @@ const failure = `{ * Generic error rendering. */ function renderError(msg: string, corrid?: string, chatSystem?: string): string { - try { - return mustache.render(failure, { - corrid, - hasCorrelationId() { - return this.corrid !== undefined; - }, - text: msg, - }); - } catch (ex) { - return `Failed to render message using template: ${ex}`; - } + return mustache.render(failure, { + corrid, + hasCorrelationId() { + return this.corrid !== undefined; + }, + text: msg, + }); } const success = `{ - "attachments": [ - { - "fallback": "{{{text}}}", - "mrkdwn_in": ["text", "pretext"], - "author_name": "Successfully ran command", - "author_icon": "https://images.atomist.com/rug/check-circle.gif?gif={{random}}", - "color": "#45B254", - "text": "{{{text}}}" - } - ] -}`; + "attachments": [ + { + "fallback": "{{{text}}}", + "mrkdwn_in": ["text", "pretext"], + "author_name": "Successfully ran command", + "author_icon": "https://images.atomist.com/rug/check-circle.gif?gif={{random}}", + "color": "#45B254", + "text": "{{{text}}}" + } + ] + } `; /** * Generic success rendering. */ function renderSuccess(msg: string, chatSystem?: string): string { - try { - return mustache.render(success, { text: msg }); - } catch (ex) { - return `Failed to render message using template: ${ex}`; - } + return mustache.render(success, { text: msg }); } export { renderIssues, renderError, renderSuccess }; diff --git a/package.json b/package.json index e549a7f..2a7203c 100644 --- a/package.json +++ b/package.json @@ -1,9 +1,9 @@ { "name": "@atomist/rugs", - "version": "0.22.0", + "version": "0.23.0", "description": "Helper functions for Rugs", "dependencies": { - "@atomist/cortex": "0.26.0", + "@atomist/cortex": "0.30.0", "@atomist/rug": "0.25.0", "mustache": "^2.3.0" },