For JavaType allow to add properties if annotation is added

[eddumelendez]

I'm moving from JUnit4 to JUnit5 and currently doing the following steps:

with JavaType c when { c.name().endsWith("Tests") } begin
  do addImport "org.junit.jupiter.api.Test"
  do addImport "org.springframework.test.context.junit.jupiter.SpringExtension"
  do addAnnotation "org.junit.jupiter.api.extension" "ExtendWith"
end

Additionally, I would like to register SpringExtension in ExtendWith to have @ExtendWith(SpringExtension.class)

[ddgenome]

@eddumelendez can you provide more information here? Are you saying you want something like this?

if addAnnotation "blah" then addProperty "blech"

where addAnnotation would return true if the annotation is actually added but false if the annotation already existed?

[eddumelendez]

@ddgenome I have updated my use case. Additionally, as you mention I would like to specify the property

[ddgenome]

@eddumelendez could you provide the resulting diff you would like to see or before and after examples?

[eddumelendez]

@ddgenome below you can find the current status, what my editor does and what I expect

Current file

public class SpringBootJunit5ApplicationTests {
}

After apply my editor

@ExtendWith
public class SpringBootJunit5ApplicationTests {
}

Expected

@ExtendWith(value = SpringExtension.class)
public class SpringBootJunit5ApplicationTests {
}

[ddgenome]

@eddumelendez can you take a look at the changes in #172 ? Rather than have a separate function to add properties to an annotation, I just changed things so you can add an annotation with properties. Your editor would look something like this:

with JavaType c when { c.name().endsWith("Tests") } begin
  do addImport "org.junit.jupiter.api.Test"
  do addImport "org.springframework.test.context.junit.jupiter.SpringExtension"
  do addAnnotation "org.junit.jupiter.api.extension" "ExtendWith(value = SpringExtension.class)"
end

Would that work for you?

[eddumelendez]

Thanks @ddgenome looks good to fit my use case

[ddgenome]

The PR is merged, so it will be in the next release.

[eddumelendez]

I think this issue should be closed, since was released in 0.10.0, right?

[ddgenome]

Yes, I was getting to it. 0.10.0 was only released a couple minutes ago!