Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

NPE if non-required parameter is set to null #458

Closed
kipz opened this issue Mar 22, 2017 · 1 comment
Closed

NPE if non-required parameter is set to null #458

kipz opened this issue Mar 22, 2017 · 1 comment
Assignees
@kipz
Labels
bug

Comments

@kipz
Copy link
Contributor

kipz commented Mar 22, 2017

e.g.

 @Parameter({description: "Repo", pattern: "@any", required: false})
    repo: string = null

java.lang.NullPointerException
at com.atomist.rug.runtime.js.JavaScriptUtils$class.com$atomist$rug$runtime$js$JavaScriptUtils$$parameterVarToParameter(JavaScriptUtils.scal
a:175)
at com.atomist.rug.runtime.js.JavaScriptUtils$$anonfun$parameters$1.applyOrElse(JavaScriptUtils.scala:118)
at com.atomist.rug.runtime.js.JavaScriptUtils$$anonfun$parameters$1.applyOrElse(JavaScriptUtils.scala:117)
at scala.PartialFunction$$anonfun$runWith$1.apply(PartialFunction.scala:141)
at scala.PartialFunction$$anonfun$runWith$1.apply(PartialFunction.scala:140)
@kipz kipz added the bug label Mar 22, 2017
@kipz kipz self-assigned this Mar 22, 2017
kipz added a commit that referenced this issue Mar 22, 2017
@kipz
Don't set default values to null if they're already null #458
f15eeae
johnsonr added a commit that referenced this issue Mar 22, 2017
@johnsonr
Merge pull request #461 from atomist/issue-458
ea18e75 
Don't set default values to null if they're already null #458
@kipz
Copy link
Contributor Author

kipz commented Mar 23, 2017

fixed.

@kipz kipz closed this as completed Mar 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kipz kipz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kipz