This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
findFile doesn't work with leading / #523
Labels
Comments
We should probably also be more explicit about this in our docs. Can the ScalaDoc for the function be updated to be more clear as part of this? |
@johnsonr I can only see findFile on the currentBackingObject in ProjectMutableView. If so, then this is an issue in |
This seems likely. So an issue should be raised there |
Can we wrap it in ProjectMutableView and strip a leading slash? |
kipz
added a commit
to atomist-attic/artifact-source
that referenced
this issue
Apr 24, 2017
kipz
added a commit
to atomist-attic/artifact-source
that referenced
this issue
Apr 24, 2017
Let's close once we have pulled in the fixed version of artifact-source. We could do that on branch containing failing test: https://github.com/atomist/rug/compare/issue-523 |
alankstewart
pushed a commit
to atomist-attic/artifact-source
that referenced
this issue
Apr 25, 2017
alankstewart
pushed a commit
to atomist-attic/artifact-source
that referenced
this issue
Apr 25, 2017
kipz
added a commit
that referenced
this issue
Apr 25, 2017
johnsonr
added a commit
that referenced
this issue
Apr 25, 2017
project.findFile fixed to work with paths starting / #523
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ProjectMutableView.findFile
can fail to find files if the path given begins with/
. A path beginning with/
should be treated like a path without an initial/
, so the file should be found in both cases.The text was updated successfully, but these errors were encountered: