Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google actions television volume #86

Closed
wants to merge 5 commits into from

Conversation

atrovato
Copy link
Owner

@atrovato atrovato commented Apr 9, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: febbae1
Status: ✅  Deploy successful!
Preview URL: https://51f34cd7.gladys.pages.dev
Branch Preview URL: https://google-actions-television-vo.gladys.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #86 (febbae1) into master (827bce8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   97.56%   97.58%   +0.01%     
==========================================
  Files         653      658       +5     
  Lines        9952    10003      +51     
==========================================
+ Hits         9710     9761      +51     
  Misses        242      242              
Impacted Files Coverage Δ
...ions/lib/deviceTypes/googleActions.curtain.type.js 100.00% <100.00%> (ø)
...ions/lib/deviceTypes/googleActions.shutter.type.js 100.00% <100.00%> (ø)
...e-actions/lib/deviceTypes/googleActions.tv.type.js 100.00% <100.00%> (ø)
...r/services/google-actions/lib/deviceTypes/index.js 100.00% <100.00%> (ø)
...e-actions/lib/smarthome/googleActions.onExecute.js 97.82% <100.00%> (+0.04%) ⬆️
...tions/lib/traits/googleActions.brightness.trait.js 100.00% <100.00%> (ø)
...ons/lib/traits/googleActions.colorSetting.trait.js 100.00% <100.00%> (ø)
...le-actions/lib/traits/googleActions.onOff.trait.js 100.00% <100.00%> (ø)
...ctions/lib/traits/googleActions.openClose.trait.js 100.00% <100.00%> (ø)
...e-actions/lib/traits/googleActions.volume.trait.js 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atrovato atrovato force-pushed the google-actions-television-volume branch from 8d29a87 to febbae1 Compare April 9, 2023 08:52
@atrovato atrovato marked this pull request as draft May 4, 2023 07:51
@atrovato atrovato closed this May 20, 2023
@atrovato atrovato deleted the google-actions-television-volume branch May 20, 2023 19:10
@atrovato atrovato linked an issue Dec 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume
1 participant