feat(doctor): detect active preexec framework #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check if "blesh" or "bash-preexec" is loaded and active in the current Bash session where `atuin doctor` is called, we make the Atuin integration script for Bash to set the environment variable `ATUIN_PREEXEC_BACKEND` and store a string when it detects "blesh" or "bash-preexec". To check whether the obtained ATUIN_PREEXEC_BACKEND is set by the current session, we record SHLVL in ATUIN_PREEXEC_BACKEND and check if it matches SHLVL of the current process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages.
Here are example outputs:
When blesh is loaded yet Atuin's preexec is not active (in the fourth case above), a warning message is shown as
Checks