Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nushell: use version.(major|minor|patch) if available #1963

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

poliorcetics
Copy link
Contributor

I added (version).major and others like it in nushell/nushell#12561 to make atuin's life easier regarding version parsing.

At the moment we obviously have to keep the support for older versions but in a year (or more?) we will be able to reasonably just use the new members I think and make that part of the script much cleaner 🤞

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 36ddd98 into atuinsh:main Apr 26, 2024
17 checks passed
@poliorcetics poliorcetics deleted the ab/push-nlpvnmumspln branch April 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants