Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing from replxx history files #2024

Merged
merged 3 commits into from
May 21, 2024

Conversation

amosbird
Copy link
Contributor

As discussed in Discord, this feature should be useful for managing history of applications which use https://github.com/AmokHuginnsson/replxx . One notable example would be ClickHouse.

I'll try to integrate atuin into clickhouse-client later.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Also Remove auto-detect for replxx which makes no sense.
@ellie
Copy link
Member

ellie commented May 18, 2024

Thank you! Would it be possible to get some test cases for this please?

@amosbird
Copy link
Contributor Author

Sure. Tests have been added.

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! :shipit:

@ellie
Copy link
Member

ellie commented May 21, 2024

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 413d3e3 into atuinsh:main May 21, 2024
14 checks passed
@amosbird
Copy link
Contributor Author

if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

That sounds perfect! I've completed the form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants