Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration password #344

Closed
conradludgate opened this issue Apr 26, 2022 · 2 comments
Closed

Registration password #344

conradludgate opened this issue Apr 26, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@conradludgate
Copy link
Collaborator

We support two flows when registering:

Upfront (arguments):

atuin register -u "..." -e "..." -p "..."

Partial (prompt):

atuin register -u "..." -e "..."
Please enter password: ...

I think we should probably suggest the latter (it's uncommon to paste passwords into the command itself)

There's also the issue that the password prompt does not enable any proper password modes, meaning that the prompt will display the password as it's typed. Might not be what is expected

@conradludgate conradludgate added the good first issue Good for newcomers label Apr 26, 2022
@conradludgate
Copy link
Collaborator Author

The same is true for login. Relevant code: https://github.com/ellie/atuin/blob/main/src/command/client/sync/login.rs#L45

@s0
Copy link
Contributor

s0 commented Jun 13, 2022

This can be closed since #424 is merged now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants