Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionStore overrides PHP session cookie lifetime setting #215

Closed
garnold opened this issue Nov 13, 2017 · 3 comments
Closed

SessionStore overrides PHP session cookie lifetime setting #215

garnold opened this issue Nov 13, 2017 · 3 comments
Assignees
Milestone

Comments

@garnold
Copy link
Contributor

garnold commented Nov 13, 2017

Hello,

Auth0\SDK\Store\SessionStore overrides the PHP session cookie lifetime setting from php.ini if the session is not already started prior to initializing Auth0:

https://github.com/auth0/auth0-PHP/blob/master/src/Store/SessionStore.php#L41

Calling session_start() in that method is ok, but setting the cookie lifetime is an unexpected side effect given that SessionStore is automatically instantiated in the Auth0\SDK\Auth0 constructor if not specified in the $config parameter.

Thanks,
Geoff.

@joshcanhelp
Copy link
Contributor

Apologies for the late response here, @garnold. I agree this is a little heavy-handed. It was done to make sure that the sessions in the PHP application match the Auth0 default sessions but both are adjustable so it makes sense to have an option for that.

Thanks for the info!

@garnold
Copy link
Contributor Author

garnold commented Mar 21, 2018

@joshcanhelp 👍

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants