Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth_time and max_age are provided in seconds #489

Closed
mvakulich opened this issue May 31, 2020 · 1 comment · Fixed by #497
Closed

auth_time and max_age are provided in seconds #489

mvakulich opened this issue May 31, 2020 · 1 comment · Fixed by #497
Labels
bug This points to a verified bug in the code

Comments

@mvakulich
Copy link

auth0-spa-js/src/jwt.ts

Line 167 in e6c3ba1

(parseInt(decoded.claims.auth_time) + options.max_age) / 1000 + leeway

here is the issue, where auth_time and max_age as per docs should be a seconds
and division by 1000 breaking token validation
@stevehobbsdev stevehobbsdev added the bug This points to a verified bug in the code label Jun 1, 2020
@stevehobbsdev
Copy link
Contributor

Thanks for raising @mvakulich - let us look into it!

@stevehobbsdev stevehobbsdev mentioned this issue Jun 5, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This points to a verified bug in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK-1699] Fix ID token validation for auth_time auth0/auth0-spa-js
2 participants
@stevehobbsdev @mvakulich