Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup flows that do not return id_token break #205

Closed
2 tasks done
rolodato opened this issue Sep 20, 2016 · 0 comments
Closed
2 tasks done

Popup flows that do not return id_token break #205

rolodato opened this issue Sep 20, 2016 · 0 comments
Labels
bug This points to a verified bug in the code

Comments

@rolodato
Copy link
Contributor

rolodato commented Sep 20, 2016

The following cases return a false positive error when using popup mode on latest auth0.js 7:

  • response_type=token without any scope (need to explicitly pass scope: '')
  • response_type=token with an audience parameter

In both of these cases, there is only an access_token returned, which returns an error after this check:

auth0.js/index.js

Lines 972 to 974 in dbe1663

if (result.id_token) {
return callback(null, _this._prepareResult(result));
}

@cristiandouce cristiandouce added bug This points to a verified bug in the code S3: Broken labels Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants