Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseHash: throw a more specific error if id_token.alg===HS256 and access_token is undefined #725

Closed
luisrudge opened this issue Mar 29, 2018 · 4 comments
Closed

parseHash: throw a more specific error if id_token.alg===HS256 and access_token is undefined #725

luisrudge opened this issue Mar 29, 2018 · 4 comments

Comments

@luisrudge
Copy link
Contributor

No description provided.

@mateoholman
Copy link

@luisrudge I'll work on this if no one else currently is!

@luisrudge
Copy link
Contributor Author

@mateoholman that would be amazing, yes 🎉

@mateoholman
Copy link

mateoholman commented Oct 5, 2018 •
edited
Loading

@luisrudge I went to edit the error message earlier and it appears you fixed this yourself a month or so after the issue was created 🎉 😄
PR #727
The error message is pretty solid and the docs were updated with the new error message.
Let me know if there is something I can add to help out, but it appears as if you can close this issue. 🍻

@luisrudge
Copy link
Contributor Author

Wow, I had totally forgot about that. Thanks for the reminder 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luisrudge @mateoholman