Lock 10.11.0 - authentication event emitted on authorization dialog cancel

[jwarykowski]

Overview

Lock authenticated event emitted when the user closes the authorization dialog by clicking cancel. I would expect this to raise the authorization_error event, however, it believes authorization was successful.

I haven't trawled through the code as of yet but wanted to raise an initial issue to see if this problem is known. If so is there a recommended workaround?

• Code snippet - see below
• Screenshots - see below
• Lock version - v10.11.0
• Browser & OS - Chrome / Mac OS Sierra

Original recording here http://recordit.co/IftdvdWU7V.

export function authenticate() {
  const AUTH0_CLIENT_ID = 'xxxxxxxxxxx'
  const AUTH0_DOMAIN = 'xxxxxxxxxxx'

  const lock = new Auth0Lock(AUTH0_CLIENT_ID, AUTH0_DOMAIN, {
    auth: { redirect: false },
    allowedConnections: ['spotify'],
    languageDictionary: { title: 'Testing!!' },
  })

  return dispatch => {
    lock.on('authenticated', (authResult) => {
      console.log(authResult) // error here!!

      if (authResult.errorDescription) return dispatch(authError(authResult.errorDescription))

      lock.getUserInfo(authResult, (error, profile) => {
        if (error) return dispatch(authError(error.errorDescription))

        localStorage.setItem('accessToken', authResult.accessToken)

        return dispatch(authSuccess(profile))
      })
    })

    lock.on('authorization_error', (error) => {
      return dispatch(authError(error.errorDescription))
    })

    lock.on('unrecoverable_error', (error) => lock.hide())

    lock.show()
  }
}

Code above returns a function for redux thunk.

[jwarykowski]

@luisrudge did you have a chance to look into this? Happy to look into this if needed.

[luisrudge]

Hi @jonathanchrisp. I'm still trying to find a reasonable fix for this, but it might take a while. For now, you can use auth: { redirect: false, responseType: 'code' }, instead, it will work just fine. The issue is when you use responseType: token (the default). Does that work for you right now?

[luisrudge]

@jonathanchrisp sorry! nevermind what I said before. I found the root cause of the issue and I'll fix it for the next release. Also, responseType code wouldn't work any way 😭

[luisrudge]

This was fixed in auth0/auth0.js#395 and will be in the next release! Thanks for your patience and all the help!