Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should confirm x5c is actually an array #111

Closed
ghost opened this issue Nov 23, 2019 · 2 comments
Closed

Should confirm x5c is actually an array #111

ghost opened this issue Nov 23, 2019 · 2 comments
Labels
closed:stale Issue or PR has not seen activity recently

Comments

@ghost
Copy link

ghost commented Nov 23, 2019

using v1.6.0

Testing against a (broken) provider that only returns a single cert in x5c as a string.

https://github.com/auth0/node-jwks-rsa/blob/master/src/JwksClient.js#L71 will succeed, because a string passes those checks.

The code should additionally check that key.x5c is an array.

@stale
Copy link

stale bot commented Feb 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Feb 21, 2020
@stale stale bot closed this as completed Feb 28, 2020
@ghost
Copy link
Author

ghost commented Feb 28, 2020

This is still a bug IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:stale Issue or PR has not seen activity recently
Projects
None yet
Development

No branches or pull requests

0 participants