Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile password update changes #375

Closed
joshcanhelp opened this issue Jan 25, 2018 · 0 comments
Closed

Profile password update changes #375

joshcanhelp opened this issue Jan 25, 2018 · 0 comments
Milestone

Comments

@joshcanhelp
Copy link
Contributor

Edit profile should check password policy and reject if unacceptable

Right now, non-implicit installs can update their password from their own WordPress profile. This will update if that password follows the password policy set on the DB connection being used. But, if the password fails, the WordPress password is updated but not the Auth0 one and there are no errors.

Probably the fastest way to get this running like it should is a check during edit profile update and rejection if Auth0 does not accept it. Probably here:

https://github.com/auth0/wp-auth0/blob/master/lib/WP_Auth0_EditProfile.php#L36

Might need to merge the update_change_password() method just below so it passes if Auth0 is changed and does not if not.

Admin edit profile password changes should be allowed

Right now, admins can change user passwords but they are not mapped to Auth0. It looks like it's just a matter of adding hooks to display and process for admins as well.

To display, hook edit_user_profile with the show_change_password method; to validate and save, hook personal_options_update/user_profile_update_errors to the validate_new_password/update_change_password methods.

@joshcanhelp joshcanhelp added this to the v3-Next milestone Jan 25, 2018
@joshcanhelp joshcanhelp self-assigned this Jan 25, 2018
@joshcanhelp joshcanhelp removed this from the v3-Next milestone Jan 30, 2018
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Jun 6, 2018
@joshcanhelp joshcanhelp removed their assignment Jun 6, 2018
@joshcanhelp joshcanhelp added the v4 label Jul 5, 2018
@joshcanhelp joshcanhelp added CH: Fixed and removed v4 labels Aug 9, 2018
@joshcanhelp joshcanhelp modified the milestones: 4.0.0, v3-Next Aug 9, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant