-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the auth0 word in the URL path triggers an authorization code exchange #351
Comments
@jmangelo - Thanks for the report here and I can confirm this behavior. |
I think the interim fix was not to used |
Sounds like a easy fix: https://github.com/auth0/wp-auth0/blob/master/lib/WP_Auth0_Routes.php#L23 |
Thanks for the digging @aslafy-z ... the fix is easy but just removing it might be breaking. I'll see if I can make this change without harming anyone 👍 |
Have to punt this to the major release, planned for early next year. I've not been able to find a simple way to keep this route as a functional callback for sites still using it so removing outright would be a breaking change. |
Steps to reproduce:
http://[wp_authority]/auth0test/
;http://[wp_authority]/auth0test/
;The above flow will trigger a second authorization code exchange when navigating to
http://[wp_authority]/auth0test/
; since there's nocode
available on that URL, the exchange will fail and appear in the Auth0 logs as a failed one due toMissing required parameter: code
.It seems that having
auth0
in the URL will trigger the code exchange to be executed as doing the above flow withhttp://[wp_authority]/thisisatest/
will not cause any additional code exchange.The text was updated successfully, but these errors were encountered: