Added translation support for a few user-facing exception messages #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idpaterson
changed the title
|
As a companion to #311 this is also now rebased on master. |
…at were previously literal strings.
idpaterson
force-pushed
the
pull-requests/translatable-exceptions
branch
from
347cbc5 to
ac969c4
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the user-facing exception messages regarding existing accounts and inability to sign up were not translatable. This does not affect developer-facing exceptions.
This issue was first encountered in #308 to which a fix has not yet been determined. I was unable to change the default "Could not create user. The registration process is not available. Please contact your site’s administrator." message to say something more specific like "Billing login is available only for subscription managers."
See #311 for the rationale of using 'wp-auth0' rather than
WPA0_LANGin this commit.