Cleanup PR for 3.5.2 #391
Merged
Cleanup PR for 3.5.2 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshcanhelp
commented
Feb 5, 2018
joshcanhelp
commented
- Fixing convertCertToPem static error (Non-static method WP_Auth0_Api_Client::convertCertToPem() should not be called statically #380)
- Fixing admin notices when saving settings
- readme.txt spelling and complete changelog with reference to main one maintained here
- Incorrect closing tag in the Setup Wizard
cocojoe
suggested changes
Feb 8, 2018
lib/WP_Auth0_Api_Client.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| protected static function convert_cert_to_pem( $cert ) { |
There was a problem hiding this comment.
Not sure we need to bother retiring this method and adding an alternative, it does not say public so we shouldn't have to worry about it. Also it is a very new addition so doubt anyone is using it.
There was a problem hiding this comment.
Why does WP coding guide go against PSR-2? 😢
There was a problem hiding this comment.
@cocojoe - Reverted.
| - Improve redirect_login error logging, JWT leeway [Github PR 317](https://github.com/auth0/wp-auth0/pull/317) - [cocojoe](https://github.com/cocojoe) | ||
| [Details](https://github.com/auth0/wp-auth0/blob/master/CHANGELOG.md#3221-2017-06-14) | ||
|
|
||
| = 3.2.5 = |
There was a problem hiding this comment.
It's nice to have a complete log. However, I'm not sure it adds any value going back before 3.0. Typically you only care about latest and greatest or at least back a few minors when you upgrade.
It can link off to changelog? for historical <3.x ?
There was a problem hiding this comment.
@cocojoe - removed
| @@ -13,9 +13,6 @@ PLUGIN_DESCRIPTION | |||
|
|
|||
| This plugin gives WordPress a new Login Widget (powered by [Auth0](https://auth0.com)) that enables: | |||
|
|
|||
| - Easy setup | |||
| + 5 minutes installation | |||
cocojoe
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.