Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #392

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Readme updates #392

merged 2 commits into from
Feb 16, 2018

Conversation

joshcanhelp
Copy link
Contributor

  • Removed all duplicate information from README.md, updated WP.org readme.txt
  • Removed incomplete hook documentation from README.md - docs PR
  • General improvements in quality, wording
  • Removing outdated screenshot

@joshcanhelp joshcanhelp added this to the v3-Next milestone Feb 8, 2018
@joshcanhelp joshcanhelp requested a review from cocojoe February 8, 2018 19:56
@cocojoe
Copy link
Member

cocojoe commented Feb 9, 2018

Pending auth0/docs#5707

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@@ -1,110 +1,31 @@
![](https://raw.githubusercontent.com/auth0/wp-auth0/master/banner-1544x500.png)

Wordpress Plugin for Auth0
Login by Auth0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for consistency from elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cocojoe - That's the name on WordPress.org and in the plugin

## Implicit Flow

There are cases where the server is behind a firewall and does not have access to internet (or at least, can't reach the Auth0 servers). In those cases, you can enable the Auth0 Implicit Flow in the advanced settings of the Auth0 Settings page.
[Please see the Installation page on auth0.com/docs](https://auth0.com/docs/cms/wordpress/installation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also mention that you should set your client type in dashboard to SPA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cocojoe - I'm removing the reference to Implicit here, not related to the added line below

## Contributions

All PR should be done towards the `dev` branch.

## Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no harm in duplicating core information like install, if you discover the repo somehow then the README should be enough to get started without having to go off elsewhere. The other repos are like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cocojoe - The other repos like SDKs? The problem comparing those is that the repo is the starting point for those whereas wp.org/plugins is where most people will start with this plugin. All of the "how to use this plugin" stuff should be on docs, where we have much better control over presentation/content. All of the basic stuff and "why to use this" should be in the WP.org readme. The repo readme is probably best as a list of links, for the most part.

What I really want to avoid, though, is maintain the same steps/info in 2 or more different places.

@joshcanhelp joshcanhelp merged commit c46a264 into dev Feb 16, 2018
@joshcanhelp joshcanhelp deleted the changed-updated-readme branch February 16, 2018 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants