Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate oauth/ro endpoint #413

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Deprecate oauth/ro endpoint #413

merged 1 commit into from
Mar 21, 2018

Conversation

joshcanhelp
Copy link
Contributor

Deprecation notices on 2 public methods that are not used anywhere in the plugin.

@joshcanhelp joshcanhelp added this to the v3-Next milestone Mar 20, 2018
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 remember deprecations must be in a minor
https://semver.org/#how-should-i-handle-deprecating-functionality

@joshcanhelp joshcanhelp merged commit 004bcb2 into dev Mar 21, 2018
@joshcanhelp joshcanhelp deleted the deprecate-ro-login branch March 21, 2018 14:38
@joshcanhelp
Copy link
Contributor Author

Fixes #410

@joshcanhelp joshcanhelp mentioned this pull request Jun 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants