Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help tab text and settings tab UX #452

Merged
merged 1 commit into from
May 1, 2018
Merged

Conversation

joshcanhelp
Copy link
Contributor

  • Fixed the help tab text to correct links and match merged changes to readme
  • Fixed the tabs jumping to the anchor link used
  • Combined settings tab JS to external file; refactored for simplicity
  • Removed unused logo styling

@joshcanhelp joshcanhelp added this to the v3-Next milestone Apr 30, 2018
@joshcanhelp joshcanhelp force-pushed the change-settings-help-tab branch from 91df5a8 to 01f151a Compare April 30, 2018 23:55
@joshcanhelp joshcanhelp force-pushed the change-settings-help-tab branch from 01f151a to 7e9ebb0 Compare May 1, 2018 15:27
@cocojoe cocojoe self-requested a review May 1, 2018 15:32
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit f6853de into dev May 1, 2018
@joshcanhelp joshcanhelp deleted the change-settings-help-tab branch May 1, 2018 15:43
@joshcanhelp joshcanhelp mentioned this pull request Jun 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants