Rename the Auto Login setting to ULP; move to features tab #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
change-auto-login-to-ulp
branch
from
c262524 to
9b121aa
Compare
luisrudge
reviewed
Oct 4, 2018
| public function render_auto_login( $args = array() ) { | ||
| $this->render_switch( $args['label_for'], $args['opt_name'], 'wpa0_auto_login_method' ); | ||
| $this->render_field_description( | ||
| __( 'Use the Universal Login Page (ULP) for authentication. ', 'wp-auth0' ) . |
There was a problem hiding this comment.
this is the only place you use (ULP) (in this PR at least). not a deal breaker for me, your call.
There was a problem hiding this comment.
@luisrudge - Used on line 225 below as well.
There was a problem hiding this comment.
damn tunnel vision. I was looking in other code blocks 😬
luisrudge
reviewed
Oct 4, 2018
| $this->render_switch( $args['label_for'], $args['opt_name'], 'wpa0_auto_login_method' ); | ||
| $this->render_field_description( | ||
| __( 'Use the Universal Login Page (ULP) for authentication. ', 'wp-auth0' ) . | ||
| __( 'When turned on, <code>wp-login.php</code> will be redirected to the hosted login page. ', 'wp-auth0' ) . |
There was a problem hiding this comment.
will redirect instead of will be redirected?
luisrudge
approved these changes
Oct 4, 2018
luisrudge
previously approved these changes
Oct 4, 2018
luisrudge
approved these changes
Oct 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
============================================
- Coverage 15.36% 15.32% -0.05%
- Complexity 1605 1606 +1
============================================
Files 69 69
Lines 5473 5489 +16
============================================
Hits 841 841
- Misses 4632 4648 +16
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There has been some general confusion around how to use the ULP with this plugin. This PR moves the setting to be more visible and changes the name to more clearly explain what the setting does. I left a reference from the old setting to the new one to help with UX.
References
Universal Login vs Embedded
Testing
No functionality changes so no testing needed.