Fix user profile saving #573
Conversation
| } | ||
|
|
||
| return false; | ||
| return $profile ? WP_Auth0_Serializer::unserialize( $profile ) : false; |
There was a problem hiding this comment.
Simplifying the return here.
|
|
||
| $currentauth0_user = get_auth0userinfo( $current_user->ID ); | ||
|
|
||
| $currentauth0_user = get_auth0userinfo( get_current_user_id() ); |
There was a problem hiding this comment.
Just need the ID here so switched to get_current_user_id().
| $data->auth0_id = WP_Auth0_UsersRepo::get_meta( $current_user->ID, 'auth0_id' ); | ||
|
|
||
| return $data; | ||
| return (object) array( |
There was a problem hiding this comment.
Type juggling to simplify object creation.
|
|
||
| return $data; | ||
| return (object) array( | ||
| 'auth0_obj' => get_auth0userinfo( get_current_user_id() ), |
There was a problem hiding this comment.
Just need the ID here so switched to get_current_user_id().
Also changed object get to get_auth0userinfo() so all these functions pass through a single one (was also doing the same job here).
| public function update_auth0_object( $user_id, $userinfo ) { | ||
| global $wpdb; | ||
| update_user_meta( $user_id, $wpdb->prefix . 'auth0_id', ( isset( $userinfo->user_id ) ? $userinfo->user_id : $userinfo->sub ) ); | ||
| update_user_meta( $user_id, $wpdb->prefix . 'auth0_obj', WP_Auth0_Serializer::serialize( $userinfo ) ); | ||
| $auth0_user_id = isset( $userinfo->user_id ) ? $userinfo->user_id : $userinfo->sub; |
There was a problem hiding this comment.
Simplify auth0_user_id setting.
| $auth0_user_id = isset( $userinfo->user_id ) ? $userinfo->user_id : $userinfo->sub; | ||
| update_user_meta( $user_id, $wpdb->prefix . 'auth0_id', $auth0_user_id ); | ||
| $userinfo_encoded = WP_Auth0_Serializer::serialize( $userinfo ); | ||
| $userinfo_encoded = wp_slash( $userinfo_encoded ); |
There was a problem hiding this comment.
Actual fix mentioned in the Changes section of the description.
| @@ -0,0 +1,87 @@ | |||
| <?php | |||
There was a problem hiding this comment.
No called anywhere, just a helper for creating new tests.
joshcanhelp
force-pushed
the
fix-user-profile-escaping
branch
from
7fd479b to
4ba4b26
Compare
| $userinfo = $this->getUserinfo(); | ||
|
|
||
| // Specially-encoded characters: ¥ £ € ¢ ₡ ₢ ₣ ₤ ₥ ₦ ₪ ₯ | ||
| $userinfo->encodedValue1 = '\u00a5 \u00a3 \u20ac \u00a2 \u20a1 \u20a2 \u20a3 \u20a4 \u20a5 \u20a6 \u20aa \u20af'; |
There was a problem hiding this comment.
Actual problematic data here. Others before are just to confirm that things are stored and retrieved as expected.
joshcanhelp
force-pushed
the
fix-user-profile-escaping
branch
2 times, most recently
from
852663a to
7f818d5
Compare
joshcanhelp
force-pushed
the
fix-user-profile-escaping
branch
from
7f818d5 to
427ccf0
Compare
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
============================================
+ Coverage 21.15% 21.27% +0.11%
Complexity 1313 1313
============================================
Files 51 51
Lines 4282 4278 -4
============================================
+ Hits 906 910 +4
+ Misses 3376 3368 -8
Continue to review full report at Codecov.
|
Changes
wp_slash()processing before saving the user profile from Auth0WP_Auth0.phptests/suiteTemplate.phpReferences
Testing
Tests were added before changes to confirm all current behavior as well as broken behavior.
Checklist