Refactor and tests for user migration get user route #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Dec 10, 2018
| @@ -89,27 +89,6 @@ public function tearDown() { | |||
| self::$error_log->clear(); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Moved to tests/testRoutes.php
joshcanhelp
commented
Dec 10, 2018
| @@ -0,0 +1,258 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Very similar to tests in #595
joshcanhelp
commented
Dec 10, 2018
| @@ -0,0 +1,107 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Moved from tests/testRoutesLogin.php
joshcanhelp
commented
Dec 10, 2018
| if ( ! $user ) { | ||
| $user = get_user_by( 'slug', $username ); | ||
| } | ||
|
|
||
| if ( $user instanceof WP_Error ) { |
There was a problem hiding this comment.
A lot of unnecessary logic here ...
joshcanhelp
force-pushed
the
improve-migration-get-user-route
branch
from
9c8677a to
2147f70
Compare
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
===========================================
+ Coverage 32.4% 33.3% +0.89%
- Complexity 1309 1312 +3
===========================================
Files 54 54
Lines 4187 4188 +1
===========================================
+ Hits 1357 1395 +38
+ Misses 2830 2793 -37
Continue to review full report at Codecov.
|
cocojoe
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0_Routes::migration_ws_get_user()for more clear usage; add unit testsWP_Auth0_Routes::error_return_array()method to handle common failure returnsTesting
Checklist