Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused IP range setting #616

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Remove unused IP range setting #616

merged 1 commit into from
Jan 8, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

Remove the unused "IP Range" setting. This was once used for whitelisting IP addresses for wp-admin but the functionality has not been available for many versions.

Testing

Adjusted existing tests for removed options.

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 3.9.0 milestone Jan 8, 2019
lbalmaceda
lbalmaceda approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@joshcanhelp joshcanhelp merged commit e428b1c into master Jan 8, 2019
@joshcanhelp joshcanhelp deleted the remove-ip-range-check branch January 8, 2019 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda