Check for email update in migration-ws-get-user endpoint #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
fix-email-change-for-user-migration
branch
from
4d2f744 to
0e215de
Compare
joshcanhelp
commented
Apr 22, 2019
| } | ||
|
|
||
| $updated_email = WP_Auth0_UsersRepo::get_meta( $user->ID, WP_Auth0_Profile_Change_Email::UPDATED_EMAIL ); | ||
| if ( $updated_email === $user->data->user_email ) { |
There was a problem hiding this comment.
Return early so no error is logged.
damieng
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an issue where sites using a custom database could not update user email addresses from the WordPress profile.
References
WP.org support forum thread
Testing
Tests for user meta changes
Tests for email update flag
Tests for get user route
Checklist