Fix VIP Go MFA screen #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
May 28, 2019
| @@ -31,7 +31,10 @@ function wp_auth0_get_option( $key, $default = null ) { | |||
| function wp_auth0_is_current_login_action( array $actions ) { | |||
|
|
|||
| // Not on wp-login.php. | |||
| if ( ! isset( $GLOBALS['pagenow'] ) || 'wp-login.php' !== $GLOBALS['pagenow'] ) { | |||
| if ( | |||
| ( isset( $GLOBALS['pagenow'] ) && 'wp-login.php' !== $GLOBALS['pagenow'] ) && | |||
There was a problem hiding this comment.
no longer an OR, is this desired?
There was a problem hiding this comment.
This is desired. Need to either have that page set to wp-login.php or that function. If the page has the function, it will not be the wp-login.php pagenow
lbalmaceda
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a query var during Auth0 login to indicate the status of the process globally. This allows for the VIP MFA form to show instead of a redirect (ULP) or Auth0 form showing (embedded). Also switches all uses of
WP_Auth0_Options::Instance()->can_show_wp_login_form()towp_auth0_can_show_wp_login_form().References
Closes #687
Testing
Checklist